Support dragging strings to new tab button #3228
Conversation
jotaemepereira
requested review from
ayoy,
a team and
amddg44
and removed request for
ayoy and
a team
There was a problem hiding this comment.
All the test steps worked exactly as described, nice work! 👏
I tested dragging images and links (just in case!) over existing tabs and noticed these resulted in searches populated with the image url / link url instead of loading the url - not sure what the expected behaviour is but it’s probably out of scope here!
Also just noting that dragging text over an existing tab causes that tab to lose its history (although pinned tabs do keep theirs); I couldn’t tell from the spec if that was the requirement or not 🙂
DragImages.mp4
Great findings @amddg44 !!! I believe both things you described are bugs:
I will address both of them. Thanks. |
- Inserts new tab when string gets dropped in the tab bar - Replaces current tab with string search when strings gets dropped on regular tab
- Fix URLs not being loaded correctly when dropping them into the tabs
jotaemepereira
force-pushed
the
juan/allow-dragging-strings-to-new-tab-button
branch
from
2992c41
to
0a96e4b
Compare
jotaemepereira
deleted the
juan/allow-dragging-strings-to-new-tab-button
branch
# By Dominik Kapusta (4) and others # Via Dominik Kapusta (4) and GitHub (2) * main: Support dragging strings to new tab button (#3228) BSK - Add feature flag for SKAN API (#3265) Ignore accents when doing a bookmark search (#3255) Update UI tests workflows to always compile the app on the supported version of Xcode (#3262) Bump C.S.S (via BSK) (#3244) Tab previews presentation implementation adjusted for the latest MouseOverView logic (#3260) Bump version to 1.106.0 (260) Default to appstore signing for fastlane match Clean up secrets in GHA workflows Update Onboarding gradients (#3248) Wait for UserScripts to be loaded for email protection (#3252) Fix UI tests failing in the CI (#3254) Fix WKDownloadMock mock (#3258) VPN Proxy stop and pixel improvements (#3239) Use fastlane match for code signing DMG builds (#3246) Implement new VPN site troubleshooting report alert (#3224) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# By Dominik Kapusta (7) and others # Via Dominik Kapusta (6) and GitHub (4) * main: (37 commits) Add visted links support (#3261) Bump version to 1.106.0 (261) Update Gemfile.lock Remove migration file (#3270) Use new AsanaCreateActionItem action (#3264) Update survey builder OS version (#3247) Support dragging strings to new tab button (#3228) BSK - Add feature flag for SKAN API (#3265) Ignore accents when doing a bookmark search (#3255) Update UI tests workflows to always compile the app on the supported version of Xcode (#3262) Bump C.S.S (via BSK) (#3244) Tab previews presentation implementation adjusted for the latest MouseOverView logic (#3260) Bump version to 1.106.0 (260) Default to appstore signing for fastlane match Clean up secrets in GHA workflows Update Onboarding gradients (#3248) Wait for UserScripts to be loaded for email protection (#3252) Fix UI tests failing in the CI (#3254) Fix WKDownloadMock mock (#3258) VPN Proxy stop and pixel improvements (#3239) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Task/Issue URL: https://app.asana.com/0/1201048563534612/1208209124965669/f
Tech Design URL:
CC:
Description:
This update adds support for dragging strings to the new tab button and the tab bar.
This request came from: #3189
dragging-strings.mov
Steps to test this PR:
Verify new tab is open with a DDG search when a string is dragged to the + button or the tab bar
Verify current tab is replaced with a DDG search when text is dragged to the tab (either regular or pinned tabs)
Definition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation